-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md in docs #2412
base: main
Are you sure you want to change the base?
Update README.md in docs #2412
Conversation
This PR is to update the installation instructions for the doc folder for html documentation reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating with your experience. Some thoughts/comments before we change the docs.
@@ -27,10 +34,14 @@ export PATH=$PATH:/Library/TeX/Distributions/.DefaultTeX/Contents/Programs/texbi | |||
|
|||
### Building Docs: | |||
```bash | |||
python setup.py build_ext --inplace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this not work for you? I think this worked for me last time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work for me, for some reason I had to go to the root and run ./build.sh, then go back down to the docs folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I agree you can do the source build this way to get a similar result, but the inplace build should do it and worked for me in the past.
./build.sh # or ./build-public.sh when deploying to aihabitat.org | ||
|
||
cd habitat-sim | ||
./build.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need --with-bullet
to compile the physics libraries in order for their docstrings to be available after building the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be it. My method somehow make the "magnum" part load, maybe that was the physics libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magnum will load either way, but some parts of the code are compiled out when bullet isn't included.
Co-authored-by: Alexander Clegg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments!
``` | ||
|
||
To build the docs, you will also need to install the following | ||
packages on Linux : | ||
To build the docs, you will also need to install textlive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: texlive
```bash | ||
python setup.py build_ext --inplace | ||
cd docs | ||
git submodule update --init | ||
./build.sh # or ./build-public.sh when deploying to aihabitat.org | ||
``` | ||
|
||
For Fedora: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The steps should be the same for Ubuntu
and Fedora
.
This PR is to update the installation instructions for the doc folder for html documentation reference.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist